jextract/jni: SwiftDictionaryMap - a native backed Map implementation#614
Open
ktoso wants to merge 1 commit intoswiftlang:mainfrom
Open
jextract/jni: SwiftDictionaryMap - a native backed Map implementation#614ktoso wants to merge 1 commit intoswiftlang:mainfrom
ktoso wants to merge 1 commit intoswiftlang:mainfrom
Conversation
ktoso
changed the title
ktoso
force-pushed
the
wip-dictionary-experiment
branch
2 times, most recently
from
4472b35 to
95e0f8b
Compare
ktoso
force-pushed
the
wip-dictionary-experiment
branch
from
95e0f8b to
e7b4cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to return and accept Swift dictionaries / Java Maps in jextracted functions in JNI mode.
We implement this by a wrapper type in Java that implements Map and delegates implementation of methods via downcalls to the underlying Swift dictionary. Actual dictionary remains in Swift native memory, though
toJavaMapallows copying it onto the java heap.We also needed to adjust how we get JNI values since we need to environment.interface.NewLocalRef in order to keep it alive when returning a java object from the native funcs. Maybe there's a better way to think about it -- open to exploring this further.
Next up we can do
Set<T>as wellresolves #609