-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: remove dependency on LDK #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
123d173 to
eb48e90
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM, I'll test it when the conflicts are solved |
# Conflicts: # .claude/commands/pr.md # app/src/main/java/to/bitkit/services/RNBackupClient.kt # gradle/libs.versions.toml
|
Need a new fix in |
|
PR now ready & tested on Regtest and Mainnet. |
|
Looks like ldk node is still at rc.4 should update to use rc.6 |
Indeed, pushed only now 👍🏻 thx for reminder in slack 🙏🏻 |
ben-kaufman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck, recovery works as before.
Integrates:
derive_node_secret_from_mnemonicto match KeysManager ldk-node#28This PR removes the dependency on LDK from the migration code by using the new
deriveNodeSecretFromMnemonicfunction exposed by ldk-node instead.Description
deriveNodeSecretFromMnemonicfunction from ldk-nodeget_node_secret_keywhich was fragiletoHeximplementations by using the shared extension functionv0.7.0-rc.3Preview
N/a
QA Notes
Tests:
1. Migration from RN
build.gradle.kts:65clear the string forapplicationIdSuffixIt should be:
applicationIdSuffix = ""