ci: add release workflows#959
Conversation
Reworking this from above, I don't really like this approach. EDIT: done and force-pushed squashed work in 1 commit. PR description updated to inform about the "migration" requirement to the new setup which ignores all but placeholder, and requires local clones to move current |
14162ef to
4aa5247
Compare
4aa5247 to
13528fa
Compare
piotr-iohk
left a comment
There was a problem hiding this comment.
Not clear about the reproducible-release.yml. Also I think that /release command and process should be adjusted such that it takes into account release.yml producing release artifacts. Please see individual comments.
13528fa to
117d56e
Compare
can't signal it was addressed by re-requesting review on the "changes requested" alert.

Related: #953
Supersedes: #867 (closed as outdated in favor of #953)
This PR:
Caution
If you already have a private debug Firebase config at
app/google-services.json, move it before checking out this PR or pullingmasterafter this PR merges:app/google-services.jsonis now the tracked placeholder for fresh clones. Keepapp/src/mainnetRelease/google-services.jsonunchanged for release builds.Description
The core change is adding protected manual
releaseandrelease-internalGitHub Actions workflows. Both workflows build signed mainnet release artifacts from protected environment secrets.releasekeeps both APK and AAB outputs for Play/GitHub release handling, whilerelease-internalproduces the mainnet APK signed with the internal keystore. These workflows do not run automatically on pushed tags;/releaseremains the release-process orchestrator until it is deliberately updated to consume workflow-produced artifacts.The reproducibility support adds a manual
Reproducible Releaseworkflow andscripts/reproduce-release.shto buildbundleMainnetRelease, recreate APK splits with bundletool, extractarm64-v8anative libraries, and upload checksum evidence. When a comparison artifact is provided,diffoscopedifferences now fail the workflow while still uploading the generated report.GitHub Actions setup:
releaseandrelease-internalGitHub environments for the protected release workflows.releaseenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,BITKIT_KEYSTORE_BASE64,BITKIT_KEYSTORE_PASSWORD,BITKIT_KEY_ALIAS, andBITKIT_KEY_PASSWORD.release-internalenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,INTERNAL_KEYSTORE_BASE64,INTERNAL_KEYSTORE_PASSWORD,INTERNAL_KEY_ALIAS, andINTERNAL_KEY_PASSWORD.GPR_USERandGPR_TOKENremain optional fallback secrets; the workflows prefer the built-in GitHub Actions token withpackages: read.Remaining upstream work for #953:
/releaseso it can trigger/download thereleaseworkflow artifacts instead of relying on local APK creation.bitkit-core-android/ Rust-native AAR builds reproducible upstream.Cargo.lock, build paths,SOURCE_DATE_EPOCH, path remapping, stripping, and published native.sochecksums.androidx.datastore:datastore-coreandnet.java.dev.jna:jnawith diffoscope evidence.Preview
N/A
QA Notes
Manual Tests
app/src/debug/google-services.json) so one file can override the checked-inapp/google-services.jsonplaceholder without dirtying Git;app/src/mainnetRelease/google-services.jsonremains the release-only path.Automated Checks
bash -n scripts/reproduce-release.sh.github/workflows/release.yml,.github/workflows/release-internal.yml, and.github/workflows/reproducible-release.ymlapp/src/debug/google-services.jsonpath while keeping release secrets atapp/src/mainnetRelease/google-services.jsonbash -nfor the release signature verification shell blocksgit diff --checkgit check-ignore -v app/src/debug/google-services.json app/src/mainnetRelease/google-services.jsonsrc/debug/google-services.jsonresolves before the checked-in rootapp/google-services.jsonplaceholder, whilesrc/mainnetRelease/google-services.jsonremains the release override. The root placeholder intentionally omits the productionto.bitkitclient.go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/reproducible-release.yml .github/workflows/release.yml .github/workflows/release-internal.yml4aa52470d: lint and detekt passed; build/E2E jobs were skipped while the PR was draft.