Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/seccomp-supervisor.c">
<violation number="1" location="src/seccomp-supervisor.c:502">
P1: SIGCHLD is no longer blocked before fork, reintroducing the race that can drop the child-exit signal before signalfd setup.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Before all kernel threads are created, we have to block SIGCHLD and let all childs inherit the blocked mask. Without this, SIGCHLD (from the supervised child process exiting) may be delivered to an LKL thread where the default ignore action silently discards it, causing the signalfd in the supervisor poll loop to never become readable. Change-Id: Ib3256f044c5b8ce9c34c223beb294c207a1f47ab
Contributor
|
Thank @RinHizakura for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before all kernel threads are created, we have to block SIGCHLD and let all childs inherit the blocked mask. Without this, SIGCHLD (from the supervised child process exiting) may be delivered to an LKL thread where the default ignore action silently discards it, causing the signalfd in the supervisor poll loop to never become readable.
This will lead to kbox hanging in the poll and never exit intermitently.
Change-Id: Ib3256f044c5b8ce9c34c223beb294c207a1f47ab