Add Change-Id trailer to commit message hook

[jserv]

Append a deterministic Gerrit-style Change-Id to every commit message: hash of tree, parent, author/committer identity, and cleaned message body. The awk block inserts the trailer in the footer, respecting existing trailer ordering.

Handles core.commentChar (including 'auto'), validates the generated hash, and fails loudly on write errors instead of silently proceeding.

Change-Id: Id606a2c2b9deae4f6bd10093cfe506fe9203da1a

---

Summary by cubic

Add a deterministic Gerrit-style Change-Id to each commit message to ensure stable change tracking. Inserts the trailer in the footer without disturbing existing trailers.

• New Features

  • Generate Change-Id from tree, parent, author/committer, and cleaned message body.
  • Skip when a valid Change-Id exists or the message is empty; ignore comments and stop at diffs; drop Signed-off-by.
  • Respect core.commentChar (including auto) during parsing.
  • Validate the 40-hex hash and abort on compute/write errors.

• Bug Fixes

  • Replace early exit with a loop break so the hook continues after validation and appends the Change-Id.

^{Written for commit 0000195. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/commit-msg.hook">

<violation number="1" location="scripts/commit-msg.hook:401">
P2: Change-Id hash generation ignores `core.commentChar` by stripping only `#` comments.</violation>

<violation number="2" location="scripts/commit-msg.hook:444">
P1: The script does not check whether the awk rewrite succeeded before moving the temp file into place.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}