Fix utility generaFix utility generation for escaped theme keystion for escaped theme keys#19587
Closed
KashviYadav09 wants to merge 1 commit intotailwindlabs:mainfrom
Closed
Fix utility generaFix utility generation for escaped theme keystion for escaped theme keys#19587KashviYadav09 wants to merge 1 commit intotailwindlabs:mainfrom
KashviYadav09 wants to merge 1 commit intotailwindlabs:mainfrom
Conversation
Member
|
Hey! Thanks for the PR, but going to say no to this one for now unless more people run into this issue. While we can merge this and fix it, our Oxide scanner (the part that extracts classes from template files) won't pick up values such as This also introduces some new Tailwind CSS syntax that is unfamiliar. I would instead recommend to use If more people run into this then I'm more than happy to re evaluate, but for now I'm going to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where utilities are not generated when theme keys contain escaped special characters (e.g.
brand\:primary).Tailwind allows escaped characters in theme configuration keys, but named utility values were not being normalized before theme lookup, which caused matching to fail.
What’s changed
Example