You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Approve. Non-blocking nits remain. Medium: Lockfile regen pulled in reqwest 0.13.2 as unintended transitive dependency in Cargo.lock:6525. Medium: serde feature no longer activated on generic-array 0.14.7 — verify crypto serde paths in tests in Cargo.lock:6566. Medium: serde feature dropped from generic-array 0.14 workspace-wide in crates/networking/extensions/agg-sig-gossip/Cargo.toml:61.
Lockfile regen pulled in reqwest 0.13.2 as unintended transitive dependencyCargo.lock:6525
The Cargo.lock regeneration caused gcloud-sdk 0.27.4 to resolve reqwest 0.13.2 in addition to reqwest 0.12.28. The workspace now ships two major versions of reqwest (0.12 and 0.13), adding a complete duplicate HTTP client stack. x402-axum also depends on reqwest 0.13.2. This wasn't present before the lockfile regen and is unrelated to the generic-array bump. Two reqwest versions means duplicated TLS stacks, connection pools, and increased binary size. More importantly, types from reqwest 0.12 an…
serde feature no longer activated on generic-array 0.14.7 — verify crypto serde paths in testsCargo.lock:6566
The dev-dependencies in agg-sig-gossip and round-based switched from enabling serde on generic-array 0.14 to 1.3. The lock file confirms generic-array 0.14.7 no longer has serde in its dependencies (only typenum, version_check, zeroize remain). This is likely correct since these crates now use generic-array 1.3.5 at runtime. However, the original comment says 'We don't use it directly, but we need to enable serde feature' — if any test code path serializes types containing GenericArray from th…
The dev-dependency comment on line 60 says 'We don't use it directly, but we need to enable serde feature.' Previously this enabled serde on generic-array 0.14, which propagated via Cargo feature unification to all transitive users of generic-array 0.14 (elliptic-curve, sec1, crypto-bigint, ff, group, etc.). After this change, the Cargo.lock confirms generic-array 0.14.7 no longer carries the serde dependency — it was removed. The serde feature is now enabled on generic-array 1.3.5 instead, …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filerustPull requests that update Rust code
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps generic-array from 0.14.7 to 1.3.5.
Release notes
Sourced from generic-array's releases.
Changelog
Sourced from generic-array's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)