Editorial: correct grammatical errors in the NOTE of Math.f16round
#3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Nov 8, 2025
bakkot
requested changes
Nov 10, 2025
Member
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
I agree this is unclear (sorry!) However, I think this edit makes it worse: it is not clear what "the value" refers to after this edit, and the only natural reading is that it refers to "the mantissa", which is nonsensical. The point is to adjust the mantissa of the binary32 so that the value of the adjusted binary32 is the one which would be produced by performing the initial cast under roundTiesToOdd.
igrep
added a commit
to igrep/ecma262
that referenced
this pull request
Nov 11, 2025
bakkot
approved these changes
Nov 11, 2025
michaelficarra
added
the
ready to merge
ljharb
changed the title
Math.f16roundMath.f16round
ljharb
force-pushed
the
editorial-Math.f16round
branch
from
7aa12ce to
ad71dc5
Compare
github-actions
bot
removed
the
request preview
|
The rendered spec for this PR is available at https://tc39.es/ecma262/pr/3716. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not completely sure whether I corrected as the original editor intended. Sorry if I get something wrong!