Skip to content

Conversation

@klmhyeonwoo
Copy link
Member

Description

  • 신규 searchQueryUtil 분류가 추가되었어요!
  • 주소창의 모든 searchParams를 메서드 하나로 확인할 수 있는 getAllQuery 메서드가 추가되었어요!

@klmhyeonwoo
Copy link
Member Author

klmhyeonwoo commented Sep 11, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.18% 203 / 263
🔵 Statements 77.18% 203 / 263
🔵 Functions 95.23% 20 / 21
🔵 Branches 91.11% 82 / 90
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
package/searchQueryUtil/getAllQuery/index.ts 89.47% 83.33% 100% 89.47% 3-4
Generated in workflow #61 for commit f6e0793 by the Vitest Coverage Report Action

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new searchQueryUtil module with a getAllQuery function that parses all URL search parameters from the browser's address bar into an object format. The function handles duplicate query parameter keys by converting them into arrays.

  • Added new searchQueryUtil module with getAllQuery function
  • Updated Vitest configuration to use jsdom environment for DOM-dependent tests
  • Exported the new utility module from the main package entry point

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vite.config.ts Added jsdom test environment for browser API testing
package/searchQueryUtil/index.ts Module entry point exporting getAllQuery function
package/searchQueryUtil/getAllQuery/index.ts Main implementation of getAllQuery utility function
package/searchQueryUtil/getAllQuery/index.test.ts Test cases for getAllQuery functionality
package/index.ts Added searchQueryUtil export to main package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@klmhyeonwoo
Copy link
Member Author

klmhyeonwoo commented Sep 11, 2025

어떻게 윈도우 객체에서 테스트를 진행할 수 있을까.. 찾아보다가 jsdom 패키지를 설치하고, environment: "jsdom"을 설정하면 window, document 등 브라우저 객체를 통해 시뮬레이션할 수 있어요!

cc. @prgmr99

@prgmr99
Copy link
Member

prgmr99 commented Sep 11, 2025

어떻게 윈도우 객체에서 테스트를 진행할 수 있을까.. 찾아보다가 jsdom 패키지를 설치하고, environment: "jsdom"을 설정하면 window, document 등 브라우저 객체를 통해 시뮬레이션할 수 있어요!

cc. @prgmr99

실제 브라우저를 띄우지 않고, 테스트 환경에서 가짜 브라우저를 띄워서 시뮬레이션을 하는 것이군여!!!👍
하나 더 배워봅니다ㅎㅎ

@klmhyeonwoo
Copy link
Member Author

승인해주시면 한번 더 버전 업 가봅시다 ㅎㅎ

Copy link
Member

@prgmr99 prgmr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴다~~!! 정말 유용하게 쓸 수 있을 것 같아요 :)

@klmhyeonwoo klmhyeonwoo merged commit f3c4e9b into main Sep 11, 2025
1 check passed
@klmhyeonwoo klmhyeonwoo deleted the feature/33 branch September 11, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants