bugfix: Fixed an error that occurred when undefined was entered in unescapeHtml and escapeHtml #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escapeHtml and escapeHtml
Member
Author
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a runtime error that occurred when undefined or null values were passed to the escapeHtml and unescapeHtml utility functions. The functions now return null or undefined as-is instead of throwing errors.
- Added null/undefined guards to both functions to handle edge cases gracefully
- Enhanced test coverage with comprehensive test suites including null/undefined scenarios
- Improved code organization by wrapping tests in describe blocks
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package/stringUtil/unescapeHtml/index.ts | Added null check guard and reformatted function for better readability |
| package/stringUtil/unescapeHtml/index.test.ts | Added comprehensive test suite with null/undefined handling tests |
| package/stringUtil/escapeHtml/index.ts | Added null check guard to prevent runtime errors |
| package/stringUtil/escapeHtml/index.test.ts | Added comprehensive test suite with null/undefined handling tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #42