Skip to content

feat: Add format number utility #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prgmr99 merged 2 commits into from
Oct 31, 2025
Merged

feat: Add format number utility #70

prgmr99 merged 2 commits into from
Oct 31, 2025

Conversation

@prgmr99
Copy link
Member

@prgmr99 prgmr99 commented Oct 28, 2025

Description

  • 숫자를 콤마(,)로 포맷팅하는 유틸리티 함수를 추가합니다.

@prgmr99 prgmr99 self-assigned this Oct 28, 2025
@prgmr99 prgmr99 added the enhancement New feature or request label Oct 28, 2025
@klmhyeonwoo
Copy link
Member

klmhyeonwoo commented Oct 28, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 81.15% 336 / 414
🔵 Statements 81.15% 336 / 414
🔵 Functions 96.96% 32 / 33
🔵 Branches 90.07% 127 / 141
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
package/formatUtil/formatNumberWithCommas/index.ts 100% 100% 100% 100%
Generated in workflow #109 for commit ebd6284 by the Vitest Coverage Report Action

@prgmr99 prgmr99 force-pushed the feature/utils-workspace-yeom branch from 0b5c5d2 to ebd6284 Compare October 28, 2025 08:43
@prgmr99
Copy link
Member Author

prgmr99 commented Oct 28, 2025

사실,, 만들 필요가 없다는 생각도 했는데 재미로 만들어보았습니다.. ^^;;

@prgmr99 prgmr99 marked this pull request as ready for review October 28, 2025 08:43
@prgmr99 prgmr99 requested a review from klmhyeonwoo October 28, 2025 08:44
@prgmr99 prgmr99 changed the title feat: Add storage utility functions and format number utility feat: Add format number utility Oct 28, 2025
klmhyeonwoo
klmhyeonwoo approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@klmhyeonwoo klmhyeonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prgmr99 prgmr99 merged commit b7e12ac into main Oct 31, 2025
1 check passed
@prgmr99 prgmr99 deleted the feature/utils-workspace-yeom branch October 31, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klmhyeonwoo klmhyeonwoo klmhyeonwoo approved these changes

Assignees

@prgmr99 prgmr99

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prgmr99 @klmhyeonwoo