fix(envs): allow version() to return Promise<string>#10226
Open
GiladShoham wants to merge 1 commit intomasterfrom
Open
fix(envs): allow version() to return Promise<string>#10226GiladShoham wants to merge 1 commit intomasterfrom
GiladShoham wants to merge 1 commit intomasterfrom
Conversation
guysaar223
approved these changes
Mar 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Envs service handler contract to support asynchronous service version resolution, allowing implementers to compute a version string lazily (e.g., via dynamic imports or reading from the filesystem).
Changes:
- Broadened
ServiceHandler.version()return type tostring | Promise<string>.
| * version of the service. optional. | ||
| */ | ||
| version?: () => string; | ||
| version?: () => string | Promise<string>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
ServiceHandler.version()to return aPromise<string>in addition to a synchronousstring, enabling async version resolution.