Adds PowerShell module checks - #108
Open
ChristianJ-TV wants to merge 1 commit into
Open
Conversation
ChristianJ-TV
added
the
Improvement
| }, | ||
| "runOptions": { | ||
| "instanceLimit": 1, | ||
| "runOn": "folderOpen" |
Contributor
There was a problem hiding this comment.
I have tested this locally and was expecting that the "Open Folder" menu option in VSCode would trigger this function to run. But where does the output go? I did not see anything even though I manually uninstalled PSScriptAnalyzer which is used as the default module to check for by the function.
Shouldn't there also be a list of our required modules here that is passed to the function to check for?
| Set-StrictMode -Version Latest | ||
| $ErrorActionPreference = 'Stop' | ||
|
|
||
| # Normalize the requested module list: remove blanks, trim whitespace, and drop duplicates. |
Contributor
There was a problem hiding this comment.
This and all comments below do not really add any new insight. They just repeat the code. I would recommend to remove them all unless there is really some kind of insight available when reading them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lightweight PowerShell module dependency validation script and a workspace task to ensure required PowerShell modules are available.