Fix SVG curve parameter extraction once more#864
Fix SVG curve parameter extraction once more#864ferdiusa wants to merge 1 commit intotecnickcom:mainfrom
Conversation
The switch from `preg_match_all` to `preg_split` in PR tecnickcom#855 broke parsing of "optimized" svg paths. In these, the "-" can be used as delimiter between numbers as well.
|
|
|
Thank you very much, @ferdiusa, for the SVG curve parameter fix - the negative-number-as-delimiter edge case in TCPDF 6 is now deprecated and no further changes will be merged into this repository. Please see the pinned issue Thank You - and the Future of TCPDF for the full explanation and the path forward. SVG rendering has been redesigned in tc-lib-pdf. If you are able to reproduce the path parsing issue there, feel free to open a PR or issue. If you need any help adapting your fix to the new library, please open a discussion and I will do my best to assist. I am leaving this PR open in case you or anyone else wishes to continue the discussion, but it is unlikely that this PR will ever be merged. Thank you again for your patience and understanding. |
4 participants
The switch from
preg_match_alltopreg_splitin PR #855 broke parsing of "optimized" svg paths. In these, the "-" can be used as delimiter between numbers as well.See Issue #767 for report by @tmhf.
The regular expression suggested in this PR reverts back to token based behaviour while keeping the fix for "e" exponents from the original issue.