Conversation
cf1e238 to
cec4c73
Compare
|
Hrmm, I am wondering if our CI is bad here. There should be a CI check that does a proto regen and confirms |
|
It was disabled during the gogoproto refactor. I noticed it in my last PR and reenabled it: 5a9f019. |
|
Assuming this check does what I think it should be doing. |
|
Not even sure that generator checker would catch the general thing we want to check (generate protos + git diff). Regardless, for this PR, we need to generate the Go code after refreshing protos. |
|
|
Update proto/api commit to latest on the versioning-3 branch and run
make protoTo bring the submodule in sync with the generated code
How did you test it?
Potential risks