Draft
Conversation
|
|
rkannan82
force-pushed
the
kannan/shutdown-rpc-logging
branch
2 times, most recently
from
99d4db3 to
2f9a578
Compare
Add print statements with timestamps at key shutdown points (initiate_shutdown, poller drain, finalize_shutdown) to correlate with TEMP_FIX poll cancellation timestamps and determine if the race is slow ShutdownWorker RPC or in-flight polls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/shutdown-rpc-logging
branch
from
2f9a578 to
2eb7184
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Temporary PR to diagnose ShutdownWorker timing. Adds error-level logs in sdk-core to trace when the ShutdownWorker RPC is sent and when it returns.
Why
Need to determine whether
TEMP_FIX: poll cancelled due to shutdownis caused by racy in-flight polls or slow ShutdownWorker RPC completion. See #1419 for context.How did you test it?
CI will produce the evidence — look for
shutdown_worker rpc: sending requestandshutdown_worker rpc: returned successfullytimestamps relative toTEMP_FIXlogs.🤖 Generated with Claude Code