Skip to content

fix: lowercase CleanStringForDNS output for RFC 1123 compliance #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarontsharp wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix: lowercase CleanStringForDNS output for RFC 1123 compliance #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/k8s/deployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ func TruncateString(s string, n int) string {
func CleanStringForDNS(s string) string {
// Keep only letters, numbers, and dashes.
re := regexp.MustCompile(`[^a-zA-Z0-9-]+`)
return re.ReplaceAllString(s, ResourceNameSeparator)
// Lowercase to ensure RFC 1123 DNS label compliance for Kubernetes resource names.
return strings.ToLower(re.ReplaceAllString(s, ResourceNameSeparator))
}

// Build ID is used as a label in k8s, and as the build ID for
Expand Down
6 changes: 6 additions & 0 deletions internal/k8s/deployments_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,12 @@ func TestComputeVersionedDeploymentName(t *testing.T) {
buildID: "image-v2.1.0-a1b2c3d4",
expectedName: "worker-name-image-v2-1-0-a1b2c3d4",
},
{
name: "uppercase characters in build ID are lowercased",
baseName: "worker-name",
buildID: "master--HEAD",
expectedName: "worker-name-master--head",
},
{
name: "exceed max length",
baseName: "worker-name-0123456789-0123456789",
Expand Down
Loading