Open
Conversation
stephanos
commented
Apr 1, 2026
|
|
||
| WorkflowIDKey = "temporalWorkflowID" | ||
| WorkflowRunIDKey = "temporalRunID" | ||
| RunIDKey = "temporalRunID" |
Contributor
Author
There was a problem hiding this comment.
Re-using this for all entities.
stephanos
force-pushed
the
stephanos/chasm-otel-event
branch
12 times, most recently
from
c46e253 to
b567c9c
Compare
stephanos
commented
Apr 2, 2026
| attrs = append(attrs, attribute.String("chasm.transition.error", retErr.Error())) | ||
| } | ||
| span := trace.SpanFromContext(ctx.goContext()) | ||
| span.AddEvent("chasm.transition", trace.WithAttributes(attrs...)) |
Contributor
Author
There was a problem hiding this comment.
main change (1): emit new OTEL event for CHASM transitions (only in debug mode)
stephanos
commented
Apr 2, 2026
| attribute.Key(idKey).String(entityID), | ||
| attribute.Key(telemetry.RunIDKey).String(e.GetRunID()), | ||
| attribute.Key("queue.task.type").String(e.GetType().String()), | ||
| attribute.Key("queue.task.id").Int64(e.GetTaskID())) |
Contributor
Author
There was a problem hiding this comment.
main change (2): support CHASM for task execution telemetry
stephanos
force-pushed
the
stephanos/chasm-otel-event
branch
4 times, most recently
from
fd13b5b to
cd52584
Compare
stephanos
commented
Apr 2, 2026
| if len(taskToken.ComponentRef) > 0 && taskToken.ActivityId != "" { | ||
| tags = append(tags, tag.ActivityID(taskToken.ActivityId)) | ||
| } | ||
| return tags |
Contributor
Author
There was a problem hiding this comment.
main change (3): allow multiple tags and draw them from ComponentRef, too
(OTEL re-uses the log tagging and converts them to OTEL tags)
Contributor
Author
There was a problem hiding this comment.
PS: bonus side effect - this also now tags SAA with an activity ID cc @dandavison
stephanos
force-pushed
the
stephanos/chasm-otel-event
branch
10 times, most recently
from
1b7d4b1 to
05fbf40
Compare
stephanos
commented
Apr 2, 2026
| if !excluded { | ||
| pd.TaskTokenGetter = "GetTaskToken()" | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
main change (4): also extract activity ID when workflow ID is present
stephanos
force-pushed
the
stephanos/chasm-otel-event
branch
2 times, most recently
from
9d050a6 to
b276629
Compare
stephanos
force-pushed
the
stephanos/chasm-otel-event
branch
from
b276629 to
f2b4fac
Compare
stephanos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
(1) Add OTEL integration to CHASM.
(2) Emit log tags for SAA.
Why?
Aid debugging.
How did you test it?