Closed
Conversation
yux0
reviewed
Apr 3, 2026
| interceptor.ServiceErrorInterceptor, | ||
| interceptor.NewFrontendServiceErrorInterceptor(logger), | ||
| // BusinessID interceptor extracts business ID and adds it to context for use by redirection policy | ||
| businessIDInterceptor.Intercept, |
Contributor
There was a problem hiding this comment.
what is the reason to move this?
| func (e *historyEngineImpl) registerNamespaceStateChangeCallback() { | ||
|
|
||
| e.shardContext.GetNamespaceRegistry().RegisterStateChangeCallback(e, func(ns *namespace.Namespace, deletedFromDb bool) { | ||
| e.shardContext.GetNamespaceRegistry().RegisterStateChangeCallbackV2(e, func(oldNs *namespace.Namespace, newNs *namespace.Namespace, deletedFromDb bool) { |
| // When updatedViaWatch is true, we skip adding to stateChangedDuringReadthrough since watch events | ||
| // trigger callbacks immediately and don't need to be queued for later delivery. | ||
| func (r *registry) updateSingleNamespace(ns *namespace.Namespace, updatedViaWatch bool) bool { | ||
| func (r *registry) updateSingleNamespace(ns *namespace.Namespace, updatedViaWatch bool) (*namespace.Namespace, bool) { |
Contributor
There was a problem hiding this comment.
can we chat about the use case? Return the old namespace seems unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a callback that allows us to inspect the old and new namespace to understand what changed
Why?
For handovers we may want to inspect the old state for finer grained tracking
How did you test it?