Nexus Standalone: Poll by stephanos · Pull Request #9780 · temporalio/temporal

stephanos · 2026-04-02T00:10:29Z

What changed?

Add polling support via PollNexusOperationExecution and DescribeNexusOperationExecution.

How did you test it?

stephanos · 2026-04-02T16:57:27Z

common/testing/protoutils/enum.go

+		enums[i] = T(values.Get(i).Number())
+	}
+	return enums
+}


seems generally useful for exhaustiveness checks in tests

stephanos · 2026-04-02T19:41:27Z

tests/nexus_standalone_test.go

 func TestDescribeStandaloneNexusOperation(t *testing.T) {
 	t.Parallel()

-	t.Run("EmptyRunID", func(t *testing.T) {


merged this one into StartAndDescribe above

bergundy

My comments are very minimal. I'm approving but please address before merging.

bergundy · 2026-04-03T17:55:17Z

chasm/lib/nexusoperation/config.go


+var LongPollTimeout = dynamicconfig.NewNamespaceDurationSetting(
+	"nexusoperation.longPollTimeout",
+	20*time.Second,


We were having discussions on slack for making this default to one minute. Please take note and adjust as we settle the discussion. Not blocking the PR.

bergundy · 2026-04-03T17:55:55Z

chasm/lib/nexusoperation/config.go

+var LongPollTimeout = dynamicconfig.NewNamespaceDurationSetting(
+	"nexusoperation.longPollTimeout",
+	20*time.Second,
+	`Timeout for nexus operation long-poll requests.`,


I think this is the maximum timeout if the context deadline is longer, no?

bergundy · 2026-04-03T21:30:15Z

chasm/lib/nexusoperation/handler.go

+			if errors.Is(err, chasm.ErrMalformedComponentRef) {
+				return nil, false, serviceerror.NewInvalidArgument("invalid long poll token")
+			}
+			if errors.Is(err, chasm.ErrInvalidComponentRef) {
+				return nil, false, serviceerror.NewInvalidArgument("long poll token does not match execution")
+			}


I saw this copied from the SAA implementation and wondering if we need this translation just for nicer errors strings or if there's a way to use the chasm predefined errors directly, e.g., by having more informative error messages on them.

I'm filing a ticket for this to unblock the merge; giving me more time to hash out a better solution with SAA crew.

bergundy · 2026-04-03T21:43:15Z

chasm/lib/nexusoperation/operation.go

+	case enumspb.NEXUS_OPERATION_WAIT_STAGE_CLOSED:
+		return o.isClosed()
+	default:
+		return false


You should validate these wait stages in the frontend and put a comment here that these are the only ones supported.

The frontend should return an invalid argument error instead of false so if a new client with a new API definition that has another variant here can know that they are running against a server that is too old.

bergundy · 2026-04-03T21:47:39Z

chasm/lib/nexusoperation/operation.go

+			resp.Outcome = &workflowservice.PollNexusOperationExecutionResponse_Result{
+				Result: successful.GetResult(),
+			}
+		} else if failure := outcome.GetFailed().GetFailure(); failure != nil {


We won't always have the response in the outcome field, sometimes we need to get it from the last attempt failure.

This is relevant for describe too. You can see the SAA code for reference.

bergundy · 2026-04-03T21:51:12Z

chasm/lib/nexusoperation/validator.go

+		return serviceerror.NewInvalidArgumentf("operation_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetOperationId()), config.MaxIDLengthLimit())
+	}
+	if len(req.GetLongPollToken()) > 0 && req.GetRunId() == "" {


We should probably validate the long poll token just in case. That's missing in the SAA validator too.

bergundy · 2026-04-03T21:53:58Z

tests/nexus_standalone_test.go

+			OperationId: "does-not-exist",
+		})
+		var notFound *serviceerror.NotFound
+		s.ErrorAs(err, &notFound)


Can you also assert that the error message is user friendly? For example does it say nexus operation not found?

bergundy · 2026-04-03T21:54:37Z

tests/nexus_standalone_test.go

+		s.ErrorAs(err, &notFound)
+	})
+
+	t.Run("WrongRunID", func(t *testing.T) {


Redundant IMHO, you're testing CHASM at this point.

bergundy · 2026-04-03T21:59:51Z

tests/nexus_standalone_test.go

+				name: "NonExistentOperationID",
+				request: &workflowservice.PollNexusOperationExecutionRequest{
+					Namespace:   s.Namespace().String(),
+					OperationId: "non-existent-op",
+					RunId:       startResp.RunId,
+					WaitStage:   enumspb.NEXUS_OPERATION_WAIT_STAGE_CLOSED,
+				},
+				expectedErr: notFoundErr,
+			},
+			{
+				name: "NonExistentRunID",
+				request: &workflowservice.PollNexusOperationExecutionRequest{
+					Namespace:   s.Namespace().String(),
+					OperationId: "test-op",
+					RunId:       "11111111-2222-3333-4444-555555555555",
+					WaitStage:   enumspb.NEXUS_OPERATION_WAIT_STAGE_CLOSED,
+				},
+				expectedErr: notFoundErr,


These two cases are redundant, the library code doesn't care why an execution is not found, that's the framework's job.

Add polling support via PollNexusOperationExecution and DescribeNexusOperationExecution. - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos force-pushed the nexus-standalone-poll branch 18 times, most recently from 2f7e5d1 to 32a04db Compare April 2, 2026 16:55

stephanos commented Apr 2, 2026

View reviewed changes

stephanos force-pushed the nexus-standalone-poll branch 5 times, most recently from f3da566 to 46661ef Compare April 2, 2026 18:12

stephanos force-pushed the feature/nexus-standalone branch from c6a4fe7 to 172314b Compare April 2, 2026 18:22

stephanos force-pushed the nexus-standalone-poll branch 3 times, most recently from 40e5047 to aacc175 Compare April 2, 2026 19:33

stephanos commented Apr 2, 2026

View reviewed changes

stephanos force-pushed the nexus-standalone-poll branch from aacc175 to 31b0dce Compare April 2, 2026 19:53

stephanos force-pushed the nexus-standalone-poll branch 2 times, most recently from 191dbbc to 6c867b4 Compare April 2, 2026 21:26

Nexus Standalone: Poll

d027a3e

stephanos force-pushed the nexus-standalone-poll branch from 6c867b4 to d027a3e Compare April 2, 2026 21:27

bergundy approved these changes Apr 3, 2026

View reviewed changes

stephanos added 9 commits April 6, 2026 09:45

assert serviceerror.NotFound error message

5a321f8

validate wait stage

3fb458b

rm redundant tests

f3913fe

decode longpoll in frontend and check ns

dc1e0bb

return LastAttemptFailure

8112404

reword longPollTimeout docs

9d878d9

mirror SAA more closely

008f37d

stabalize test

39017e1

wait 10s

1ee7cd0

stephanos merged commit a4f682a into feature/nexus-standalone Apr 6, 2026
45 checks passed

stephanos deleted the nexus-standalone-poll branch April 6, 2026 21:42

stephanos added a commit that referenced this pull request Apr 7, 2026

Nexus Standalone: Poll (#9780)

e3f6109

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 7, 2026

Nexus Standalone: Poll (#9780)

c6836ae

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 7, 2026

Nexus Standalone: Poll (#9780)

ac4a2f1

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 7, 2026

Nexus Standalone: Poll (#9780)

10d3595

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 7, 2026

Nexus Standalone: Poll (#9780)

83bfb53

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 8, 2026

Nexus Standalone: Poll (#9780)

6a0bd6e

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 8, 2026

Nexus Standalone: Poll (#9780)

88281af

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 9, 2026

Nexus Standalone: Poll (#9780)

c50d8ba

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 9, 2026

Nexus Standalone: Poll (#9780)

de4ebc5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 9, 2026

Nexus Standalone: Poll (#9780)

e2dd500

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stephanos added a commit that referenced this pull request Apr 9, 2026

Nexus Standalone: Poll (#9780)

1419695

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Conversation

stephanos commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

How did you test it?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergundy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stephanos commented Apr 2, 2026 •

edited

Loading