Add subscription for autoEnable and handle changes#9781
Merged
majiru merged 14 commits intotemporalio:mainfrom Apr 10, 2026
Merged
Add subscription for autoEnable and handle changes#9781majiru merged 14 commits intotemporalio:mainfrom
majiru merged 14 commits intotemporalio:mainfrom
Conversation
dnr
reviewed
Apr 2, 2026
dnr
reviewed
Apr 7, 2026
dnr
approved these changes
Apr 9, 2026
Contributor
dnr
left a comment
dnr
left a comment
There was a problem hiding this comment.
some style nits and suggestions, but approving now to reduce delay
| } | ||
|
|
||
| // TestAutoEnableV2ConfigChange tests that switching autoEnable triggers unload when effective config changes | ||
| func TestAutoEnableV2ConfigChange(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Should it be a parameterized test func so we can test more combinations of: {newMatcher config, enableFairness config, fairness state} -> expected result when autoenable flipped {on, off} ?
Co-authored-by: David Reiss <dnr@dnr.im>
stephanos
pushed a commit
that referenced
this pull request
Apr 13, 2026
## What changed? Move autoenable to a subscription, and check when it changes to see if we need to unload. ## Why? When we disable autoEnable as we approach GA we need to be able to go back to the old dynamic config being the source of truth. --------- Co-authored-by: David Reiss <dnr@dnr.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Move autoenable to a subscription, and check when it changes to see if we need to unload.
Why?
When we disable autoEnable as we approach GA we need to be able to go back to the old dynamic config being the source of truth.
How did you test it?