CHASM: Expose approximate execution state size#9797
Merged
yycptt merged 6 commits intotemporalio:mainfrom Apr 6, 2026
Merged
Conversation
fretz12
reviewed
Apr 3, 2026
| ScheduleToStartTimeout: a.GetScheduleToStartTimeout(), | ||
| StartToCloseTimeout: a.GetStartToCloseTimeout(), | ||
| StateTransitionCount: ctx.StateTransitionCount(), | ||
| StateTransitionCount: executionInfo.StateTransitionCount, |
Contributor
There was a problem hiding this comment.
we'll need to add an ApproximateStateSize field to ActivityExecutionInfo after this PR is merged
fretz12
approved these changes
Apr 3, 2026
Contributor
|
lgtm from the ACT side |
rodrigozhou
reviewed
Apr 3, 2026
rodrigozhou
approved these changes
Apr 3, 2026
awln-temporal
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
chasmContext.ExecutionInfo().ApproximateStateSizechasm.ExecutionInfowhich is for visibility tochasm.ExecutionVisibilityInfochasmContext.StateTransitionCount()andExecutionCloseTime()method part of the newExecutionInfo()method.Why?
How did you test it?