Implement stand-alone callback executions#9805
Draft
Quinn-With-Two-Ns wants to merge 4 commits intotemporalio:mainfrom
Draft
Implement stand-alone callback executions#9805Quinn-With-Two-Ns wants to merge 4 commits intotemporalio:mainfrom
Quinn-With-Two-Ns wants to merge 4 commits intotemporalio:mainfrom
Conversation
Quinn-With-Two-Ns
force-pushed
the
stand-alone-callbacks
branch
from
69fab2e to
e6c7326
Compare
Add standalone callback execution support as first-class CHASM entities independent of workflows. A standalone callback is a durable Nexus completion delivery mechanism managed through new WorkflowService RPCs.
Quinn-With-Two-Ns
force-pushed
the
stand-alone-callbacks
branch
from
e6c7326 to
36d259c
Compare
| EnableChasm = NewNamespaceBoolSetting( | ||
| "history.enableChasm", | ||
| false, | ||
| true, |
Contributor
Author
There was a problem hiding this comment.
Just set these for easy testing
| // the operation has started and no operation token is provided. This message is used by the | ||
| // callback invocation layer to detect this specific condition and retry without triggering | ||
| // the circuit breaker. | ||
| const ErrMsgOperationNotStarted = "nexus operation not started yet" |
Contributor
Author
There was a problem hiding this comment.
We discussed we also want to wait a bit on the receiving side to avoid this race condition, but I think this code is needed wither way.
chasm/lib/callback/statemachine.go
Outdated
| if reason == "" { | ||
| reason = "callback execution terminated" | ||
| } | ||
| cb.LastAttemptFailure = &failurepb.Failure{ |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a hack using LastAttemptFailure to store the failure in this case, we could add a dedicated field for failure as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add standalone callback execution support as first-class CHASM entities independent of workflows. A standalone callback is a durable Nexus completion delivery mechanism managed through new WorkflowService RPCs.
Why?
Allow users to implement custom async Nexus operations.
How did you test it?
API PR: temporalio/api#753