Skip to content

Optimize TestReactivationSignalCache_Deduplication_* test timers#9820

Open
Shivs11 wants to merge 1 commit intomainfrom
shivam/test-optimization
Open

Optimize TestReactivationSignalCache_Deduplication_* test timers#9820
Shivs11 wants to merge 1 commit intomainfrom
shivam/test-optimization

Conversation

@Shivs11
Copy link
Copy Markdown
Member

@Shivs11 Shivs11 commented Apr 4, 2026

What changed?

Reduce drainage timer overrides from 10s grace + 30s refresh to 3s grace

Why?

  • pace

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • none

Note

Low Risk
Test-only timing changes that reduce wait durations; main risk is increased flakiness on slow CI if the shorter drainage intervals are insufficient.

Overview
Speeds up the TestReactivationSignalCache_Deduplication_* functional tests by reducing overridden drainage timers (using 3s visibility grace and 10s refresh) and updating the corresponding wait windows.

Removes the now-unused testExtraLongVersionDrainageRefreshInterval constant.

Reviewed by Cursor Bugbot for commit a275170. Bugbot is set up for automated code reviews on this repo. Configure here.

Reduce drainage timer overrides from 10s grace + 30s refresh to 3s grace
+ 10s refresh across all 4 cache dedup tests (StartWorkflow, SignalWithStart,
UpdateOptions, Reset). This cuts each test from ~95s to ~41s while maintaining
the critical invariant that wait durations match the overridden config values
(see #9352). Remove now-unused testExtraLongVersionDrainageRefreshInterval.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Shivs11 Shivs11 requested review from a team as code owners April 4, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant