Optimize TestReactivationSignalCache_Deduplication_* test timers#9820
Open
Optimize TestReactivationSignalCache_Deduplication_* test timers#9820
Conversation
Reduce drainage timer overrides from 10s grace + 30s refresh to 3s grace + 10s refresh across all 4 cache dedup tests (StartWorkflow, SignalWithStart, UpdateOptions, Reset). This cuts each test from ~95s to ~41s while maintaining the critical invariant that wait durations match the overridden config values (see #9352). Remove now-unused testExtraLongVersionDrainageRefreshInterval. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Reduce drainage timer overrides from 10s grace + 30s refresh to 3s grace
Why?
How did you test it?
Potential risks
Note
Low Risk
Test-only timing changes that reduce wait durations; main risk is increased flakiness on slow CI if the shorter drainage intervals are insufficient.
Overview
Speeds up the
TestReactivationSignalCache_Deduplication_*functional tests by reducing overridden drainage timers (using3svisibility grace and10srefresh) and updating the corresponding wait windows.Removes the now-unused
testExtraLongVersionDrainageRefreshIntervalconstant.Reviewed by Cursor Bugbot for commit a275170. Bugbot is set up for automated code reviews on this repo. Configure here.