Add support for adding caller Namespace even if it's not in list of allowed Namespace options for Nexus endpoint#3167
Draft
laurakwhit wants to merge 3 commits intomainfrom
Draft
Add support for adding caller Namespace even if it's not in list of allowed Namespace options for Nexus endpoint#3167laurakwhit wants to merge 3 commits intomainfrom
laurakwhit wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| active = false, | ||
| selected, | ||
| destructive = false, | ||
| disabled = false, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'null' is not assignable to type 'string'.
| {#snippet allowedCallerNamespacesTable()} | ||
| <Card class="flex flex-col gap-4"> | ||
| <div class="flex items-center gap-2"> | ||
| <h5>{translate('nexus.allowed-caller-namespaces')}</h5> |
Contributor
There was a problem hiding this comment.
⚠️ 'allowedCallerNamespaces' is possibly 'undefined'.
| previousPageButtonLabel={translate('common.previous-page')} | ||
| nextPageButtonLabel={translate('common.next-page')} | ||
| pageButtonLabel={(page) => translate('common.go-to-page', { page })} | ||
| variant="primary" |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string[] | undefined' is not assignable to type 'string[]'.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
/nexus/{endpoint}page soDescriptionisn't pushed to bottom ifAllowed Caller Namespacesare defined.allowCustomValueprop toComboboxthat lets users type and add values not present in the predefined options list.allowCustomValueon theAllowed Caller Namespacesfield in the Nexus endpoint form, so users can specify Namespaces that they don't have access to (and therefore aren't listed).Screenshots (if applicable) 📸
Nexus Endpoint Details Page
Allowed Caller Namespaces Input
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
On Cloud > Navigate to a Nexus endpoint create/edit form
Allowed Caller NamespacesfieldChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-3533Docs
Any docs updates needed?