Skip to content

fix(workflow): remove extra vertical padding from history toolbar#3179

Merged
rossnelson merged 1 commit intomainfrom
split-timeline-history-tabs-remove-gaps
Feb 24, 2026
Merged

fix(workflow): remove extra vertical padding from history toolbar#3179
rossnelson merged 1 commit intomainfrom
split-timeline-history-tabs-remove-gaps

Conversation

@rossnelson
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Verify the Timeline and Event History tabs toolbar has no extra vertical gaps
  • Confirm spacing looks correct across different viewport sizes (responsive xl:gap-8)

After splitting into Timeline and Event History tabs (#3109), the
py-2 padding on the toolbar container created unnecessary vertical
gaps. The child elements already provide their own spacing.
@rossnelson rossnelson requested a review from a team as a code owner February 24, 2026 17:22
@rossnelson rossnelson requested review from KATIETOLER and removed request for a team February 24, 2026 17:22
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 24, 2026 5:22pm

Request Review

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd bot commented Feb 24, 2026

Warnings
⚠️

📊 Strict Mode: 2 errors in 1 file (0.2% of 1118 total)

src/lib/layouts/workflow-history-layout.svelte (2)
  • L239:2: Type 'string | undefined' is not assignable to type 'string'.
  • L240:2: Type 'string | undefined' is not assignable to type 'string'.

Generated by 🚫 dangerJS against 1cfcdea

@rossnelson rossnelson merged commit 4801f8d into main Feb 24, 2026
17 checks passed
@rossnelson rossnelson deleted the split-timeline-history-tabs-remove-gaps branch February 24, 2026 17:34
temporal-cicd bot pushed a commit that referenced this pull request Feb 24, 2026
Auto-generated version bump from 2.45.4 to 2.46.0

Bump type: minor

Changes included:
- [`1acf17c0`](1acf17c) docs: Add AUTHENTICATION.md referenced by README (#3157)
- [`7d2368a2`](7d2368a) Corrected location of output directory (#3155)
- [`1f2900c0`](1f2900c) [DT-3584] Migrate Nexus form to Superforms with validation (#3158)
- [`f60fe1bf`](f60fe1b) feat(workflow): split Event History into Timeline and Event History tabs (#3109)
- [`4801f8dc`](4801f8d) fix(workflow): remove extra vertical padding from history toolbar (#3179)
- [`4ba52557`](4ba5255) Fix some minor bugs in the Standalone Activities UI (#3177)
rossedfort added a commit that referenced this pull request Feb 24, 2026
Auto-generated version bump from 2.45.4 to 2.46.0

Bump type: minor

Changes included:
- [`1acf17c0`](1acf17c) docs: Add AUTHENTICATION.md referenced by README (#3157)
- [`7d2368a2`](7d2368a) Corrected location of output directory (#3155)
- [`1f2900c0`](1f2900c) [DT-3584] Migrate Nexus form to Superforms with validation (#3158)
- [`f60fe1bf`](f60fe1b) feat(workflow): split Event History into Timeline and Event History tabs (#3109)
- [`4801f8dc`](4801f8d) fix(workflow): remove extra vertical padding from history toolbar (#3179)
- [`4ba52557`](4ba5255) Fix some minor bugs in the Standalone Activities UI (#3177)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants