Skip to content

fix(workflow): restore input/result height and breadcrumb link#3188

Merged
rossnelson merged 1 commit intomainfrom
fix/restore-input-result-height-and-breadcrumb
Feb 25, 2026
Merged

fix(workflow): restore input/result height and breadcrumb link#3188
rossnelson merged 1 commit intomainfrom
fix/restore-input-result-height-and-breadcrumb

Conversation

@rossnelson
Copy link
Collaborator

Summary

  • Restores CodeBlock maxHeight from 120px back to 300px (the pre-split value) in input-and-results-payload.svelte. The height was reduced during the timeline/history split (feat(workflow): split Event History into Timeline and Event History tabs #3109), making input and result sections too small to read without scrolling.
  • Fixes the "back to workflow execution" breadcrumb in workflow-header.svelte to use routeForTimeline instead of routeForEventHistory, so clicking back from an event detail lands on the Timeline tab (the new default).

Link audit

All other routeForEventHistory usages are correct — they're either the History tab link itself, links to specific events within history, or import/utility code.

Test plan

  • Workflow detail page input and result sections show full content without excessive scrolling (up to 300px)
  • Viewing an event detail and clicking the breadcrumb back link lands on Timeline tab, not History
  • History tab link in tab bar still works correctly

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 25, 2026 5:30pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 25, 2026

Warnings
⚠️

📊 Strict Mode: 13 errors in 1 file (1.2% of 1113 total)

src/lib/layouts/workflow-header.svelte (13)
  • L136:37: Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
  • L137:45: Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
  • L141:13: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L142:13: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L144:13: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L169:9: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L170:9: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L172:9: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L180:20: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L236:12: Type 'string | undefined' is not assignable to type 'string'.
  • L271:11: 'workflow' is possibly 'null'.
  • L313:12: 'workflow' is possibly 'null'.
  • L313:12: 'workflow.searchAttributes' is possibly 'undefined'.

Generated by 🚫 dangerJS against edb5cfa

- Restore CodeBlock maxHeight from 120px to 300px (pre-split value)
  in input-and-results-payload. The height was reduced during the
  timeline/history split, making input and result sections too small.

- Change "back to workflow execution" breadcrumb from routeForEventHistory
  to routeForTimeline so it navigates to the default tab.
@rossnelson rossnelson force-pushed the fix/restore-input-result-height-and-breadcrumb branch from b923828 to edb5cfa Compare February 25, 2026 17:29
@rossnelson rossnelson merged commit d541be9 into main Feb 25, 2026
16 checks passed
@rossnelson rossnelson deleted the fix/restore-input-result-height-and-breadcrumb branch February 25, 2026 17:36
temporal-cicd bot pushed a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)
rossedfort added a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants