Skip to content

Fix workflow errors#3190

Merged
rossedfort merged 8 commits intomainfrom
fix-workflow-errors
Feb 25, 2026
Merged

Fix workflow errors#3190
rossedfort merged 8 commits intomainfrom
fix-workflow-errors

Conversation

@laurakwhit
Copy link
Collaborator

@laurakwhit laurakwhit commented Feb 25, 2026

Summary

Fixes several regressions introduced by the Timeline/Event History tab split (#3109).

Workflow error alerts restored

  • Add back workflow task failure and no-workers alerts to both Timeline and Event History layouts
  • These alerts were present in the original combined view but dropped during the split
  • Move call stack error below workflow details for better visual hierarchy

Sticky toolbar fixes

  • Fix sticky header offset: add md:pt-2 padding so the toolbar aligns flush with the app navigation bar instead of floating below it
  • Remove border-b from Event History toolbar to eliminate double border with the table container's own border
  • Reduce z-index from z-30 to z-10 on both toolbars to prevent overlapping other UI elements

Test plan

  • Workflow with task failure shows red error alert on both Timeline and Event History tabs
  • Workflow with no workers shows warning alert on both tabs
  • Sticky toolbar sits flush under the navigation bar when scrolling (no gap)
  • No double border between Event History toolbar and the table
  • Toolbar doesn't overlap dropdowns or modals (z-index)
  • Call stack error appears below workflow details, not above

laurakwhit and others added 3 commits February 25, 2026 12:09
- Add md:pt-2 to timeline and history toolbar sticky headers to align
  with the app navigation bar
- Remove border-b from history toolbar to prevent double border with
  the table container's own border
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 25, 2026 8:13pm

Request Review

@@ -179,6 +180,7 @@
</div>
<CodecServerErrorBanner />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.

</div>
<div class="flex w-full flex-col">
<TimelineGraph {workflow} {groups} viewportHeight={undefined} />
<TimelineGraph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 25, 2026

Warnings
⚠️

📊 Strict Mode: 19 errors in 4 files (1.7% of 1113 total)

src/lib/holocene/table/paginated-table/paginated.svelte (1)
  • L22:13: Type 'null' is not assignable to type 'string'.
src/lib/layouts/workflow-header.svelte (13)
  • L137:37: Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
  • L138:45: Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
  • L142:13: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L143:13: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L145:13: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L170:9: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L171:9: Type 'boolean | undefined' is not assignable to type 'boolean'.
  • L173:9: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L181:20: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L238:12: Type 'string | undefined' is not assignable to type 'string'.
  • L273:11: 'workflow' is possibly 'null'.
  • L315:12: 'workflow' is possibly 'null'.
  • L315:12: 'workflow.searchAttributes' is possibly 'undefined'.
src/lib/layouts/workflow-history-layout.svelte (2)
  • L239:2: Type 'string | undefined' is not assignable to type 'string'.
  • L240:2: Type 'string | undefined' is not assignable to type 'string'.
src/lib/layouts/workflow-timeline-layout.svelte (3)
  • L143:7: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L153:14: 'workflow' is possibly 'null'.
  • L154:9: 'workflow' is possibly 'null'.

Generated by 🚫 dangerJS against 03f5b94

Sits above table header (z-10) but below more actions menu (z-20).
@laurakwhit laurakwhit marked this pull request as ready for review February 25, 2026 19:56
@laurakwhit laurakwhit requested review from a team and rossedfort as code owners February 25, 2026 19:56
@rossedfort rossedfort merged commit dbe3114 into main Feb 25, 2026
17 checks passed
@rossedfort rossedfort deleted the fix-workflow-errors branch February 25, 2026 20:23
temporal-cicd bot pushed a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)
rossedfort added a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants