COM-191 - prefill CloudFormation template params in Launch Stack link#3619
Draft
rossnelson wants to merge 1 commit into
Draft
COM-191 - prefill CloudFormation template params in Launch Stack link#3619rossnelson wants to merge 1 commit into
rossnelson wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The serverless worker deployment "Launch Stack" button (CloudFormation, under the "I don't have a role yet" accordion) previously linked to a bare CloudFormation console URL and prefilled nothing. This wires the form's field values into the launch URL using AWS's
param_<ParameterName>=<value>convention so the CloudFormation quick-create form opens with the template and parameters prefilled.Changes
compute-fields.svelte:launchStackHrefis now a$derived.by()that, whencfnTemplateUrlis set, builds a#/stacks/quickcreate?templateURL=...URL and appends:param_AssumeRoleExternalIdfromroleExternalIdparam_LambdaFunctionARNsfromlambdaArnRoleNameis left to the template default (no form field exists for it). Eachparam_*entry is omitted when its source field is empty, and the template URL plus every param value areencodeURIComponent-encoded. WhencfnTemplateUrlis falsy, the existing bare-console fallback is preserved.Decisions worth a look
#/stacks/quickcreatefor the prefilled-but-editable UX. Can pin to#/stacks/create/reviewfor strict parity with the S3 export / Kinesis audit-log forms if preferred.Notes for the integrator (out of scope here)
End-to-end this requires cloud-ui to pass a real, publicly-hosted
cfnTemplateUrland repack the tarball. The localtemporal-worker-role.yamlis download-only and currently has noParameterssection; the parameterized hosted template is handled separately in cloud-ui.Test plan
pnpm checkcleanpnpm lintcleantemplateURL,param_AssumeRoleExternalId, andparam_LambdaFunctionARNs, and omits empty params