Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
legion2002
reviewed
Apr 24, 2026
|
|
||
| The T3 call must use the tuple-form signature above. A flattened seven-argument signature is not equivalent. In Foundry, that flattened form hashes to `0x203e2736`, which the precompile rejects as an unknown selector. | ||
|
|
||
| ### Signature type for passkeys |
Contributor
There was a problem hiding this comment.
This section feels unnecessary here
|
|
||
| #### T2 -> T3 changes | ||
|
|
||
| At T3, spending limits can recur through `TokenLimit.period`, call scoping becomes a first-class restriction type, and access-key-signed transactions can no longer create contracts after T3 activation. |
Contributor
There was a problem hiding this comment.
We should clarify that a period of 0, means a one time spending limit.
Co-authored-by: Tanishk Goyal <goyaltanishk02@gmail.com>
0xrusowsky
approved these changes
Apr 24, 2026
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
really nice improvements, agreed with the suggestions though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.