Skip to content

Fix ICU Unicode normalization data symbol name and link configuration in TF-Text. #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 27, 2026
Merged

Fix ICU Unicode normalization data symbol name and link configuration in TF-Text. #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions third_party/icu/BUILD.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,10 @@ cc_library(
[
"icu4c/source/common/*.c",
"icu4c/source/common/*.cpp",
"icu4c/source/stubdata/*.cpp",
],
),
hdrs = glob([
"icu4c/source/common/*.h",
"icu4c/source/stubdata/*.h",
]),
copts = [
"-DU_COMMON_IMPLEMENTATION",
Expand Down
6 changes: 3 additions & 3 deletions third_party/icu/data/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ exports_files(["LICENSE"])
# $ ICU_DATA_FILTER_FILE=filters.json ./runConfigureICU Linux
# $ make clean && make
# $ cd data/out/tmp
# $ genccode icudt64l.dat
# $ echo 'U_CAPI const void * U_EXPORT2 uprv_getICUData_other() { return icudt64l_dat.bytes; }' >> icudt64l_dat.c
# This creates icudt64l_dat.c which you can rename and move in here.
# $ genccode -e icudt77 icudt77l.dat
# $ echo 'U_CAPI const void * U_EXPORT2 uprv_getICUData_other() { return icudt77_dat.bytes; }' >> icudt77_dat.c
# This creates icudt77_dat.c which you can rename to normalization_data.c and move in here.
cc_library(
name = "icu_normalization_data",
srcs = ["normalization_data.c"],
Expand Down
4 changes: 2 additions & 2 deletions third_party/icu/data/normalization_data.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ U_CDECL_BEGIN
const struct {
double bogus;
uint8_t bytes[223376];
} icudt77l_dat={ 0.0, {
} icudt77_dat={ 0.0, {
144,0,218,39,20,0,0,0,0,0,2,0,67,109,110,68,
1,0,0,0,3,0,0,0,32,67,111,112,121,114,105,103,
104,116,32,40,67,41,32,50,48,49,54,32,97,110,100,32,
Expand Down Expand Up @@ -13973,4 +13973,4 @@ const struct {
};
U_CDECL_END

U_CAPI const void * U_EXPORT2 uprv_getICUData_other() { return icudt77l_dat.bytes; }
U_CAPI const void * U_EXPORT2 uprv_getICUData_other() { return icudt77_dat.bytes; }
Loading