Add more typing #559
Open
Add more typing #559
+2,155
−1,068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmer
force-pushed
the
fix-typing
branch
2 times, most recently
from
3d76abf to
1815666
Compare
Remove testtools.assertions, testtools.compat, testtools.run, testtools.matchers.*, testtools.monkey, and testtools.runtest from mypy strict override list as they now have full type annotations.
Explicitly capture the return value from addBoth() when adding validation callbacks to Deferred objects. While addBoth() modifies the Deferred in place and returns it, explicitly using the return value ensures the properly chained Deferred is returned from _run_setup and _run_teardown. This fixes a test failure specific to Python 3.12 where the validation callback chain wasn't being properly handled.
The typing changes in commit 282db18 inadvertently broke the async setUp/tearDown validation by: 1. Renaming the return value variable from `ret` to `setup_result`/`teardown_result` 2. Adding an unnecessary `is not None` check before the duck-typing check These changes, while logically equivalent, caused test failures on Python 3.12. Reverting to the original variable names and removing the None check fixes the issue while maintaining type safety with appropriate type: ignore comments. Fixes the test failure in: tests.twistedsupport.test_runtest.TestAsyncSetUpTearDownValidation.test_async_setup_with_deferred_upcall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.