docs(dom-testing-library): Update Keyboard events example code#869
Open
sarahgabrielle wants to merge 1 commit intotesting-library:mainfrom
Open
docs(dom-testing-library): Update Keyboard events example code#869sarahgabrielle wants to merge 1 commit intotesting-library:mainfrom
sarahgabrielle wants to merge 1 commit intotesting-library:mainfrom
Conversation
Update Keyboard events example code to include ```charCode``` in the event properties object
sarahgabrielle
changed the title
eps1lon
reviewed
Jun 25, 2021
|
|
||
| ```javascript | ||
| fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter' }) | ||
| fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter', charCode: 13 }) |
Member
There was a problem hiding this comment.
Thanks for the feedback. I dont' think we want to document deprecated event properties though (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode). Is the charCode important here for any framework?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
charCodein the event properties object - this update relates to issue 269