Finalize renaming MAX_WAITSOCK --> ROBOT_TIMEOUT#2985
Merged
Conversation
The commit 51a35b0 changed variable names but there were leftovers. Also before the tiemout values were reduced, so that the check may run faster. What was left were that some timeout values were still too long. Thus MAX_WAITSOCK is now completely changed to ROBOT_TIMEOUT . Also when the ROBOT check identified something as potentially vulnerable, the timeout value ist increased to 8 seconds which is less than in 3.2 . Tests however showed so far that there were no false positives or negatives. Moreover it changes the local variable robottimeout to robot_timeout. This PR fixes #2983 for 3.3dev .
... which may led to false positives Also in a number of tests the timeout was re-adjusted so that the robot check performs ~25% faster -- on MacOS. On Linux it's about the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 51a35b0 changed variable names but there were leftovers. Also before the tiemout values were reduced, so that the check may run faster. What was left were that some timeout values were still too long. Thus MAX_WAITSOCK is now completely changed to ROBOT_TIMEOUT . Also when the ROBOT check identified something as potentially vulnerable, the timeout value ist increased to 8 seconds which is less than in 3.2 . Tests however showed so far that there were no false positives or negatives.
Moreover it changes the local variable robottimeout to robot_timeout.
This PR fixes #2983 for 3.3dev .
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()