Fix nightly browserstack test workflows#73
Draft
rwood-moz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added explicit required secrets to the reusable workflow instead of relying on secrets: inherit. Updated each platform workflow to pass the required secrets explicitly.
Why?
The github action workflows for the new nightly E2E tests that run in BrowserStack are failing.
Why it failed: GitHub reusable workflows have a secret boundary, and environment secrets are especially sharp here. GitHub’s docs say inherited secrets can work, but also warn that environment secrets cannot be passed from the caller via workflow_call because workflow_call does not support environment at the caller boundary. That likely left BROWSERSTACK_USERNAME empty when the BrowserStack setup action ran. See GitHub’s reusable workflow docs: Using inputs and secrets.
Limitations and Notes
Patch by Codex AI.
Applicable Issues
Fixes #72.