fix(web): prevent session navigation on right-click - #1636
Open
techotaku39 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: initial. No issues found in the added or modified lines. Residual risk is limited to browser-specific context-menu event ordering; the focused regression test covers the affected
mouseup-before-contextmenusequence.
Testing
- Not run (automation). GitHub integration check passed; the main test workflow was still in progress at review time.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
A desktop right-click on a session row could trigger the row's click handler after the context-menu event, navigating to that session unexpectedly.
Summary
useLongPress.Validation
bun run --cwd web test -- src/hooks/useLongPress.test.tsx— 15 passed.bun typecheck— passed.pwsh -NoProfile -File .\scripts\Invoke-HapiTaskPlaywright.ps1 -Name session-right-click-navigation -Suite Root terminal-wrap-fidelity.spec.ts— 2 passed.bun run build— passed.bun run test:shared— 279 passed./sessionsURL unchanged.Related Issues
None
AI Disclosure
OpenAI Codex (GPT-5.6) assisted with investigation, implementation, testing, and PR drafting.