fix(web): improve fullscreen image preview toolbar layout - #1665
fix(web): improve fullscreen image preview toolbar layout#1665techotaku39 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
Review mode: initial
No issues found in the latest full diff. Residual testing risk: the responsive assertions at web/src/components/ImagePreview.test.tsx:48 verify Tailwind utility classes in jsdom, not computed desktop/mobile layout; the main GitHub test check was still in progress at review time.
Testing
- Not run (automation); PR code was not executed. GitHub
integrationpassed;testremained in progress.
HAPI Bot
…eview-toolbar-align # Conflicts: # web/src/components/AssistantChat/AttachmentItem.tsx # web/src/components/ImagePreview.tsx
There was a problem hiding this comment.
Findings
- None.
Summary
Review mode: follow-up after new commits
No issues found in the latest full diff. Residual testing gaps: web/src/components/ImagePreview.test.tsx:48 verifies responsive behavior through Tailwind utility classes rather than computed desktop/mobile layout, and the four caller paths that supply file size metadata are not all covered by propagation assertions. The GitHub test check was still in progress at review time.
Testing
- Not run (automation); PR code was not executed. GitHub
integrationpassed;testremained in progress.
HAPI Bot
Problem / Motivation
The fullscreen image preview toolbar used inconsistent text glyph controls and did not expose the image's original dimensions or file size. Desktop and mobile layouts also require different metadata placement.
Summary
Validation
bun typecheck— passed.bun run test:e2e -- terminal-wrap-fidelity.spec.ts— passed, 2/2 tests.bun run test:web -- src/components/ImagePreview.test.tsx src/components/AssistantChat/AttachmentItem.test.tsx src/components/AssistantChat/messages/ToolMessage.test.ts src/components/AssistantChat/messages/ToolMessage.generatedMedia.test.tsx— passed, 4 files and 19 tests.bun run build— passed.git diff --check— passed.Related Issues
None
Risk / Rollback
UI-only change with optional file metadata propagation. No API, database, dependency, or migration changes are included. Rollback can be performed by reverting this change.
AI Disclosure
Implemented and validated with OpenAI Codex (GPT-5.6).