Skip to content

ci: drop the codex-home config seed that breaks TOML parsing - #1670

Merged
tiann merged 1 commit into
tiann:mainfrom
junmo-kim:fix/codex-action-seed-duplicate
Aug 23, 2026
Merged

ci: drop the codex-home config seed that breaks TOML parsing#1670
tiann merged 1 commit into
tiann:mainfrom
junmo-kim:fix/codex-action-seed-duplicate

Conversation

@junmo-kim

@junmo-kim junmo-kim commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #1667: its codex-home config seed doesn't work — the action appends its own [model_providers.codex-action-responses-proxy] table to config.toml instead of merging, so every Codex workflow fails with a TOML duplicate key error (verified on an external PR run). And since v1.12 rejects the flaky-relay retry overrides in codex-args, the tuning cannot be expressed on v1.12 at all.

This pins all three workflows to v1.11, the last release that accepts those deliberate overrides under drop-sudo, and drops the seed — restoring the original behavior fully intact. Once the action either merges existing config or exposes first-class inputs for proxy tuning (same root cause as openai/codex-action#80), upgrading should be straightforward.

tiann#1667 pinned @v1.12 and moved the flaky-relay stream retry tuning from
codex-args into a seeded codex-home config.toml, but the action appends
its own [model_providers.codex-action-responses-proxy] table instead of
merging, so every Codex workflow fails with a TOML duplicate key error.
The overrides cannot be expressed on v1.12 at all.

Pin all three workflows to v1.11, the last release that accepts these
deliberate codex-args overrides under drop-sudo, restoring the original
behavior.
@junmo-kim
junmo-kim force-pushed the fix/codex-action-seed-duplicate branch from 140a980 to 8a12e64 Compare August 22, 2026 10:31
@junmo-kim

Copy link
Copy Markdown
Contributor Author

@tiann Sorry, the fix from yesterday (#1667) didn't hold. The config seed it added collides with the action's own [model_providers.codex-action-responses-proxy] table (the action appends rather than merges), so every Codex workflow is now failing with a TOML duplicate key error. This PR drops the seed and pins v1.11 instead, which accepts the original codex-args overrides, so review automation is back to its pre-breakage behavior. Details in the body.

@tiann
tiann merged commit f5a86a8 into tiann:main Aug 23, 2026
2 of 3 checks passed
@junmo-kim
junmo-kim deleted the fix/codex-action-seed-duplicate branch August 23, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants