Open
Conversation
Author
|
Seems like the clippy and integration test is failing. Clippy makes sense: But for the integration tests I'll look into that |
Signed-off-by: andylokandy <andylokandy@hotmail.com>
72d1520 to
61f4425
Compare
|
batch_put() api would give the following error: tikv server: v6.1.3 I also tested tikv v4.0. It does not throw this error. Example: use tikv_client::{KvPair, RawClient};
#[tokio::main]
async fn main() -> Result<(), ()> {
let client = RawClient::new(vec!["127.0.0.1:12379"], None).await.unwrap();
let kvpair1: KvPair = KvPair("PD".to_owned().into(), "Go".to_owned().into());
let kvpair2: KvPair = KvPair("TiKV".to_owned().into(), "Rust".to_owned().into());
let pairs: Vec<KvPair> = vec![kvpair1, kvpair2];
match client.batch_put(pairs).await {
Ok(_) => println!("pairs are inserted"),
Err(e) => println!("error: {}", e),
};
Ok(())
}Output: |
Author
|
Indeed, that was also my observation. I'm not sure what's going on and I don't have a lot of time to work on this. I'll try to get to the bottom of this in the next couple of days though. If anyone has any clues, please share ;) |
|
just a wild guess. It may have something to do with the pb files. Let me also cross check the go client code to see if there is any finding. |
andylokandy
reviewed
Jul 9, 2023
| @@ -262,18 +274,25 @@ impl<PdC: PdClient> Client<PdC> { | |||
| /// # }); | |||
| /// ``` | |||
| pub async fn put(&self, key: impl Into<Key>, value: impl Into<Value>) -> Result<()> { | |||
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #324 with the following additions:
(KvPair, u64)toKvPairWithTTL