Skip to content

TINY-13630: Remove race condition from port binding#162

Merged
jscasca merged 12 commits intomasterfrom
feature/TINY-13630
Feb 12, 2026
Merged

TINY-13630: Remove race condition from port binding#162
jscasca merged 12 commits intomasterfrom
feature/TINY-13630

Conversation

@jscasca
Copy link
Contributor

@jscasca jscasca commented Jan 29, 2026

Related Ticket: TINY-13630

Description of Changes:

  • Remove race conditions from port binding
  • Move scratch dir for compiled code

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@jscasca jscasca requested a review from a team as a code owner January 29, 2026 05:15
Copy link
Contributor

@ltrouton ltrouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy will know this code better but logically I think the code looks good 👍

Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a very good thing here but it seems to be by accident. Which means it's incomplete.

Lean into the way port zero operates, fix up the manual testing entry point, and this will be a great change.

@jscasca jscasca requested a review from TheSpyder February 11, 2026 02:58
Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jscasca jscasca merged commit a7f101b into master Feb 12, 2026
5 checks passed
@jscasca jscasca deleted the feature/TINY-13630 branch February 12, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants