fix(cli): render Unicode output with legacy encodings - #826
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows and redirected streams configured as CP1252, the CLI could raise
UnicodeEncodeErrorbefore showing its banner or graph summaries because those views use box-drawing characters. Reconfigurable standard streams now switch to UTF-8 at startup, while UTF-8, encoding-less, and non-reconfigurable streams keep their existing behavior.Validation
mainwith a CP1252TextIOWrapperbefore applying the fix.main()regression passes on Python 3.10 and 3.13 and verifies bothstdoutandstderr.tests/test_cli.py: 18 passed; the one deselected test is an existing Windows failure reproduced on cleanmain.main.PYTHONIOENCODING=cp1252render both the startup banner and graph summaries and exit successfully.Post-Deploy Monitoring & Validation
No additional operational monitoring is required because this changes local CLI output and has no deployed service surface. During review and the next Windows release, a healthy run exits successfully and renders readable Unicode when
PYTHONIOENCODING=cp1252;UnicodeEncodeError,charmap, or unreadable redirected output are failure signals. Revert this commit to restore the previous stream behavior if those signals appear.