Open
Conversation
Author
|
Hi @tlecomte , just wanted to gently ping you to see if this PR is something you're interested in? As I mention, I am happy to make more changes to better match how you think it should work. If you'd rather not add the feature at all, also completely fine, of course; I can distribute builds to the folks I know who would like the feature. (Also, sad to have to do, but I will note that I am a human, no "AI" was used to write this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Something I've wanted & heard from other people, but had to work around, is the ability to annotate target frequencies in the spectrogram view. I've implemented that here, trying to keep the changes as minimal as possible. Right now, the lines are hard-coded green, toggle-able by right-clicking, and do not persist. If this change is amenable for merging, I'd be happy to improve those deficiencies.
A screenshot showing three targets added: