Open
Conversation
madsmtm
commented
Nov 23, 2018
| return self.request.body | ||
|
|
||
| def request_parameters(self): | ||
| return self.request.query_arguments |
Author
There was a problem hiding this comment.
This implementation is incomplete, HTTPServerRequest.query_arguments returns a mapping that points to bytes, not str. I'm not sure how to cleanly fix this, we could maybe use RequestHandler.decode_argument, but this would cause us to automatically parse the arguments before somebody actually needs them. Another option is to add a helper class around RequestHandler.get_query_argument with __getitem__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to suggest adding
Request.request_parametersandResource.params, which follows the idea ofResource.data. This would allow you to easily create endpoints that have e.g. optional filtering.Example usage (untested):
Which would allow
GET /resource/?slice=1,3to returndata[1, 3](["two", "three"]).If this gets approved, I'll update the docs and test suite