fix(server): make email and name optional in OIDC user info #14041
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
OIDCUserInfoSchemato make thenameandemailfields optional because these values are already resolved through the configurableclaimsMap. Since different OIDC Providers may use different claim names—or omit certain claims entirely—the schema should not require fields that are not guaranteed to exist.This problem is particularly visible when using Synology SSO Server’s OIDC Provider. Synology SSO Server returns a
usernameclaim instead ofnameorpreferred_username. Because the previous schema requirednameandemail, parsing the userinfo response resulted in validation errors despite the presence of equivalent data under different claim keys.By marking
nameandemailas optional, the schema now correctly reflects real-world provider behavior, allowingclaimsMapto map the appropriate fields without causing runtime errors.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.