fix: avoid flicker when controlled pane sizes also change content#889
Open
akx wants to merge 1 commit into
Open
fix: avoid flicker when controlled pane sizes also change content#889akx wants to merge 1 commit into
akx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my app, you can collapse panes to thin "sliver" windowshades; when you do that, the content also changes (to the pane's title, rendered vertically).
Since
react-split-paneis usinguseEffectto sync a controlled width into its state, this means the pane's content changes before the width does, leading to a flicker of about one frame where the pane's content is the vertical title, but the width is still wide.This fixes that by using
useLayoutEffect, when available, for that sync.