Fix TODO #396 and #397: safe stream handling & receipt handling#740
Merged
tomusdrw merged 2 commits intotomusdrw:masterfrom Oct 24, 2025
Merged
Fix TODO #396 and #397: safe stream handling & receipt handling#740tomusdrw merged 2 commits intotomusdrw:masterfrom
tomusdrw merged 2 commits intotomusdrw:masterfrom
Conversation
Contributor
aman879
commented
Oct 24, 2025
aman879
commented
- Added safe handling for block streams in wait_for_confirmations
- Properly handle None receipt instead of panic in send_transaction_with_confirmation_
- Uses ok_or_else instead of expect
- Ensures no panics in production scenarios
bayk
pushed a commit
to mwcproject/rust-web3
that referenced
this pull request
Jan 15, 2026
…t handling (tomusdrw#740) * Fix TODO tomusdrw#396 and tomusdrw#397: safe stream handling & receipt handling * Fix TODOs tomusdrw#396 & tomusdrw#397 and format code with rustfmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.