🐛 fix(win32): capture process probe errors#645
Merged
Conversation
Plain ctypes calls can lose the error set by OpenProcess, causing a stale marker probe to treat a dead PID as live. Bind kernel32 with last-error capture and explicit signatures so liveness decisions use the failing call's error.
gaborbernat
force-pushed
the
fix/630-windows-last-error
branch
from
1527fbb to
0739ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows
SoftFileLockprocess probes readGetLastError()through a plain ctypes loader. Another ctypes call could overwrite the thread error afterOpenProcessfailed, causing filelock to classify a dead PID as live. This closes issue #630.Filelock now binds kernel32 with
use_last_error=True, declares each function signature, and readsctypes.get_last_error()after a failed probe. Access-denied and unverifiable probes continue to treat the recorded holder as live.