🐛 fix(api): retain acquisition path identity#647
Merged
Conversation
Release could resolve a changed parent symlink, leave the holder's deadlock record behind, or delete a peer's record. Store the identity owned by the active hold and clear only that identity during release and rollback.
gaborbernat
force-pushed
the
fix/632-stable-acquisition-key
branch
from
63c2fe4 to
5fb47fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release resolved a mutable parent symlink twice. If its target changed while held, the original registry record remained, and release could delete a live holder's record at the new target. A finite or nonblocking acquisition that raised could also delete its peer's record. This closes issue #632.
The lock context now stores the path identity owned by the first physical acquisition. Recursive acquisition preserves it, while final release, forced release, and rollback clear only that identity. Backend paths and singleton construction retain their existing behavior, and Unix release avoids a second
realpath()lookup.