Allow for more valid method calls with block arguments#291
Open
jketema wants to merge 4 commits intotree-sitter:masterfrom
Open
Allow for more valid method calls with block arguments#291jketema wants to merge 4 commits intotree-sitter:masterfrom
jketema wants to merge 4 commits intotree-sitter:masterfrom
Conversation
Author
|
@amaanq @WillLillis Could one of you review this? We often see the issue fixed here reported in CodeQL, so this would help us. |
|
Just ran into this for us in our CodeQL use case as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support specific cases where a block argument is not followed by an identifier. This uses the approach suggested in #218.
I used version 14 of the ABI when regenerating the parser files. I'm not sure if this was strictly necessary, but this matched what was there.
Fixes: #218
Fixes: #244
Fixes: #290