Skip to content

fix(firmware): add missing requried true to JSONs release#150

Open
karliatto wants to merge 1 commit intomasterfrom
fix/add-required-true-to-missing-releases
Open

fix(firmware): add missing requried true to JSONs release#150
karliatto wants to merge 1 commit intomasterfrom
fix/add-required-true-to-missing-releases

Conversation

@karliatto
Copy link
Member

When we changed to the new releases JSONs, we used trezor/data as source of truth, but it was actually not really 100% since there were previous changes that were done to the copy of those releases JSONs in Suite but not here, this PR is trying to align with that

Issue in Suite trezor/trezor-suite#22028

PR in Suite that is adding the changes trezor/trezor-suite#22135

Link to old commit were those releases.json were still in Suite and they had some "required": true different with the ones in trezor/data repository - https://github.com/trezor/trezor-suite/tree/0c16c5f1fc2cdf2c394afa9b0e99a0787d7d9d5d/packages/connect-common/files/firmware

@vdovhanych
Copy link
Member

@karliatto is this still relevant?

@karliatto
Copy link
Member Author

@karliatto is this still relevant?

Yes, if we want to have the same information in https://github.com/trezor/trezor-suite/tree/develop/packages/connect-common/files/firmware and here.

The idea is that with the new changes I wanted trezor/data to be the source of truth, but I missed some changes that in the past were done in Suite but not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants